video/external: Make OpenH264 support optional at build time #17878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjarosh
reviewed
Sep 12, 2024
kjarosh
reviewed
Sep 12, 2024
kjarosh
reviewed
Sep 12, 2024
torokati44
force-pushed
the
optional-openh264
branch
from
e398bf6
to
e8966c7
Compare
…4` feature And enable it in desktop and tests.
Thereby deduplicating the version number of it.
torokati44
force-pushed
the
optional-openh264
branch
from
e8966c7
to
e9c0145
Compare
kjarosh
approved these changes
Sep 18, 2024
|
Thanks for the review! ^^ |
|
Thank YOU for working on H264 ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first (more ready and conflicty, but less risky and controversy) part of #16794 split out. The rest can be more or less additive after this, once I finally get back to it.
I know that
external_videoitself is already a blanket feature that disables this; and having that enabled, butopenh264not, is somewhat silly, but ... bear with me? 😀