desktop: Use FilePicker for picking files in ActionScript #17864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjarosh
force-pushed
the
file-reference-picker
branch
from
c8dedb8
to
bf35ec5
Compare
Dinnerbone
approved these changes
Sep 15, 2024
This change emphasizes that we want to pick a file to open by Ruffle contrary to picking files e.g. from ActionScript.
This method makes it possible to easily integrate an existing RFD dialog with Ruffle, i.e. make sure it's a proper child of the main window and ensure there's only one picker present at any moment.
This improves the experience of picking files from AS, as the pickers will now be properly integrated with Ruffle.
Dinnerbone
force-pushed
the
file-reference-picker
branch
from
bf35ec5
to
991ce06
Compare
kjarosh
removed
the
waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the experience of picking files from AS, as the pickers will now be properly integrated with Ruffle (child/parent relationship + making sure only one picker is present at any moment).