core: Strip BOM in URLLoader text data #17513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are you sure that this is done in URLLoader, and not in ByteArray? There's already some BOM-related logic in ByteArray, so I wonder if it just needs to be extended |
According to uqers, in FP, URLLoader uses URLStream, so it's done in URLStream/readUTFBytes like in ByteArray |
Mesteery
force-pushed
the
strip-bom-urlloader
branch
from
6b10705
to
334bfe5
Compare
Mesteery
force-pushed
the
strip-bom-urlloader
branch
2 times, most recently
from
76f901a
to
247f89d
Compare
|
I would really appreciate a test for this! |
Mesteery
force-pushed
the
strip-bom-urlloader
branch
3 times, most recently
from
0608cbb
to
698fc62
Compare
Lord-McSweeney
approved these changes
Aug 23, 2024
Dinnerbone
force-pushed
the
strip-bom-urlloader
branch
from
698fc62
to
8c818cc
Compare
Dinnerbone
added
A-core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.