Implement surfaceSelector in Context3D.setRenderToTexture #15495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrian17
approved these changes
Mar 9, 2024
| @@ -612,15 +612,6 @@ pub fn set_render_to_texture<'gc>( | |||
| ); | |||
| } | |||
|
|
|||
| if surface_selector != 0 { | |||
There was a problem hiding this comment.
Do we want the same validation as FP has?
ArgumentError - for a mismatched surfaceSelector parameter. The value must be 0 for 2D textures and 0..5 for cube maps
There was a problem hiding this comment.
I hesitated to merge myself because I wasn't sure how strongly you wanted this to be addressed.
torokati44
added
waiting-on-author
torokati44
force-pushed
the
surface-selector
branch
from
9ba1e7a
to
56de39e
Compare
Aaron1011
force-pushed
the
surface-selector
branch
from
56de39e
to
e2e9882
Compare
adrian17
force-pushed
the
surface-selector
branch
2 times, most recently
from
7c3b358
to
950f7e0
Compare
Lord-McSweeney
approved these changes
Oct 11, 2024
moulins
approved these changes
Oct 11, 2024
This still needs a test, but I'm planning to add that in a follow-up PR
torokati44
force-pushed
the
surface-selector
branch
from
950f7e0
to
4d32dfa
Compare
n0samu
removed
the
waiting-on-author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This still needs a test, but I'm planning to add that in a follow-up PR
Fixes #15487