Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release): pull hotfix-release/v1.85.1 into main #3898

Merged
merged 5 commits into from
Nov 21, 2024

Conversation

devops-github-rudderstack
Copy link
Contributor

👑 An automated PR

aashishmalik and others added 3 commits November 21, 2024 14:49
* fix: stringifying session ID for airship

* fix: test case numbering fix

* fix: adding more test cases

* fix: review comment addressed

* fix: edit error message

* chore: refactored code

* chore: handled stringifcation in convertToUuid

* fix: adding test cases

* fix: small edit

* fix: code review addressed

---------

Co-authored-by: krishnachaitanya <[email protected]>
shrouti1507
shrouti1507 previously approved these changes Nov 21, 2024
utsabc
utsabc previously approved these changes Nov 21, 2024
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 93.75000% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.47%. Comparing base (f580f20) to head (49a6f18).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
src/v0/destinations/airship/transform.js 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3898      +/-   ##
==========================================
- Coverage   90.47%   90.47%   -0.01%     
==========================================
  Files         616      615       -1     
  Lines       32311    32320       +9     
  Branches     7675     7677       +2     
==========================================
+ Hits        29234    29242       +8     
- Misses       2853     2854       +1     
  Partials      224      224              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@devops-github-rudderstack
Copy link
Contributor Author

shrouti1507
shrouti1507 previously approved these changes Nov 21, 2024
Copy link

sonarcloud bot commented Nov 21, 2024

@aashishmalik aashishmalik merged commit 275e971 into main Nov 21, 2024
30 checks passed
@aashishmalik aashishmalik deleted the hotfix-release/v1.85.1 branch November 21, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants