Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: onboard linkedin audience destination #3857

Merged
merged 14 commits into from
Nov 18, 2024
Merged

Conversation

ItsSudip
Copy link
Member

@ItsSudip ItsSudip commented Nov 7, 2024

What are the changes introduced in this PR?

We are onboarding new destination linkedin audience.

What is the related Linear task?

Resolves INT-45

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added in new readability format?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@ItsSudip ItsSudip requested a review from a team as a code owner November 7, 2024 08:36
@ItsSudip ItsSudip requested review from a team and sivashanmukh as code owners November 7, 2024 08:45
@devops-github-rudderstack
Copy link
Contributor

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 90.19608% with 5 lines in your changes missing coverage. Please review.

Project coverage is 90.47%. Comparing base (e90d2ad) to head (1852c39).
Report is 9 commits behind head on develop.

Files with missing lines Patch % Lines
src/cdk/v2/destinations/linkedin_audience/utils.ts 88.88% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3857      +/-   ##
===========================================
+ Coverage    89.05%   90.47%   +1.41%     
===========================================
  Files          618      615       -3     
  Lines        33071    32296     -775     
  Branches      7814     7673     -141     
===========================================
- Hits         29452    29219     -233     
+ Misses        3336     2821     -515     
+ Partials       283      256      -27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Nov 18, 2024

@ItsSudip ItsSudip merged commit f3ff409 into develop Nov 18, 2024
24 of 25 checks passed
@ItsSudip ItsSudip deleted the feat.linkedin_audience branch November 18, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants