-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: sources v2 spec support along with adapters #3810
Conversation
Test report for this run is available at: https://test-integrations-dev.s3.amazonaws.com/integrations-test-reports/rudder-transformer/3810/test-report.html |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3810 +/- ##
========================================
Coverage 89.04% 89.05%
========================================
Files 610 618 +8
Lines 32982 33071 +89
Branches 7797 7814 +17
========================================
+ Hits 29370 29452 +82
- Misses 3329 3336 +7
Partials 283 283 ☔ View full report in Codecov by Sentry. |
Regarding the failed The github actions workflow Here are the changes to be done:
|
af46127
to
5705f2e
Compare
Quality Gate passedIssues Measures |
Changes made in this PR
/v2/sources/:source
( v2 endpoint support has been added )adaptInputToVersion
has been upgraded to support v2 -> v1 and v2 -> v0 conversionsourceTransformRoutine
is upgraded to support the new return type (including errors) from the adapter.upgradedToSourceTransformV2
is introduced.What is the related Linear task?
Resolves INT-2755 (partly)
Objectives
This PR is part of the webhook sources specification upgrade project. This partly resolves step-1 of this project.
Corresponding documentation of the project
Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?
Any new dependencies introduced with this change?
N/A
Any new generic utility introduced or modified. Please explain the changes.
N/A
Any technical or performance related pointers to consider with the change?
N/A
@coderabbitai review
Developer checklist
My code follows the style guidelines of this project
No breaking changes are being introduced.
All related docs linked with the PR?
All changes manually tested?
Any documentation changes needed with this change?
Is the PR limited to 10 file changes?
Is the PR limited to one linear task?
Are relevant unit and component test-cases added in new readability format?
Reviewer checklist
Is the type of change in the PR title appropriate as per the changes?
Verified that there are no credentials or confidential data exposed with the changes.