Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: klaviyo bulk upload and BingAds OC #5305

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

yashasvibajpai
Copy link
Contributor

Description

add fixes for

  • Klaviyo Bulk Upload
  • BingAds Offiine conversions integrations

Linear Ticket

Resolves INT-2820 INT-2916

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

ItsSudip and others added 2 commits November 19, 2024 13:08
* chore: handle 500kb limit, refactor to service impl

* chore: fix mock

* chore: fix mock newline

* chore: fix apiservice newline

* chore: move error
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 36.55172% with 92 lines in your changes missing coverage. Please review.

Project coverage is 73.47%. Comparing base (94aa254) to head (08f4af1).
Report is 1 commits behind head on release/1.38.x.

Files with missing lines Patch % Lines
...destinationmanager/klaviyobulkupload/apiService.go 12.76% 82 Missing ⚠️
...tionmanager/klaviyobulkupload/klaviyobulkupload.go 80.00% 8 Missing and 2 partials ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##           release/1.38.x    #5305      +/-   ##
==================================================
+ Coverage           73.40%   73.47%   +0.07%     
==================================================
  Files                 424      425       +1     
  Lines               60243    59965     -278     
==================================================
- Hits                44221    44060     -161     
+ Misses              13578    13434     -144     
- Partials             2444     2471      +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@yashasvibajpai yashasvibajpai merged commit 9c9ef73 into release/1.38.x Nov 19, 2024
58 checks passed
@yashasvibajpai yashasvibajpai deleted the fix.integration_klaviyo_bingadsoc branch November 19, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants