chore: rsources flaky test - start services before all #2650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 43.73% // Head: 45.31% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2650 +/- ##
==========================================
+ Coverage 43.73% 45.31% +1.57%
==========================================
Files 191 287 +96
Lines 40483 47745 +7262
==========================================
+ Hits 17707 21635 +3928
- Misses 21672 24745 +3073
- Partials 1104 1365 +261
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
atzoum
force-pushed
the
chore.rsourcesFlakyTest
branch
from
7fc0dc4
to
ba8d152
Compare
atzoum
force-pushed
the
chore.rsourcesFlakyTest
branch
10 times, most recently
from
a927921
to
50ed1a8
Compare
atzoum
force-pushed
the
chore.rsourcesFlakyTest
branch
from
50ed1a8
to
c55edc2
Compare
fracasula
approved these changes
Nov 7, 2022
| else | ||
| $(eval TEST_CMD = SLOW=0 go test) | ||
| $(eval TEST_OPTIONS = -p=1 -v -failfast -shuffle=on -coverprofile=profile.out -covermode=atomic -vet=all --timeout=15m) | ||
| $(eval TEST_OPTIONS = -p=1 -v -failfast -shuffle=on -coverprofile=profile.out -covermode=count -coverpkg=./... -vet=all --timeout=15m) |
There was a problem hiding this comment.
We'll have to remember to switch it back to atomic once we'll get to run tests in parallel. Just saying it out loud 😅
Comment on lines
+1024
to
+1026
| func randomString() string { | ||
| return strings.ReplaceAll(uuid.Must(uuid.NewV4()).String(), "-", "") | ||
| } |
There was a problem hiding this comment.
FYI, we got a helper for random strings, maybe it can work well in this case: https://github.com/rudderlabs/rudder-server/blob/master/testhelper/rand/randString.go
pChondros
approved these changes
Nov 7, 2022
chandumlg
approved these changes
Nov 7, 2022
This was referenced Nov 7, 2022
Closed
This was referenced Dec 1, 2022
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Attempting to fix a flaky test & adding some more logging
Security