fix: snowflake identifier issue #2471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achettyiitr
force-pushed
the
fix.snowflakeIdentifierIssue
branch
from
d2c7827
to
bf719d8
Compare
achettyiitr
force-pushed
the
fix.snowflakeIdentifierIssue
branch
from
e58bba0
to
22f919b
Compare
Codecov ReportBase: 37.33% // Head: 36.13% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## release/1.1.x #2471 +/- ##
=================================================
- Coverage 37.33% 36.13% -1.21%
=================================================
Files 200 200
Lines 40477 39644 -833
=================================================
- Hits 15114 14324 -790
+ Misses 24447 24415 -32
+ Partials 916 905 -11
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
psrikanth88
approved these changes
Sep 22, 2022
Jayachand
approved these changes
Sep 23, 2022
Merged
atzoum
pushed a commit
that referenced
this pull request
Sep 23, 2022
atzoum
added a commit
that referenced
this pull request
Sep 23, 2022
* fix: snowflake identifier issue (#2471) * chore: release 1.1.2 (#2472) Co-authored-by: Akash Chetty <[email protected]> Co-authored-by: Rudder Bot (server team) <[email protected]>
fracasula
pushed a commit
that referenced
this pull request
Oct 3, 2022
fracasula
added a commit
that referenced
this pull request
Oct 3, 2022
* fix: close http response body only if there is no error (#2447) * exp: test to reproduce * fix: fallback to standar lib json and report * fmt * fix: snowflake identifier issue (#2471) * chore: release 1.1.2 (#2472) * lint * Apply suggestions from code review Co-authored-by: Francesco Casula <[email protected]> * pr fixes * chore: changing log entry * chore: removing unnecessary inits * chore: re-panicking Co-authored-by: Aris Tzoumas <[email protected]> Co-authored-by: Akash Chetty <[email protected]> Co-authored-by: Rudder Bot (server team) <[email protected]> Co-authored-by: Francesco Casula <[email protected]> Co-authored-by: Francesco Casula <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use namespace as an identifier for snowflake queries. No need to add a database since we are already adding that in the connection itself.
Notion Ticket
https://www.notion.so/rudderstacks/Schema-identifier-for-Snowflake-d3a9c90bd69f44a893e600c869958f6d
Security