Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: too many concurrent timer firings #5283

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Conversation

lvrach
Copy link
Member

@lvrach lvrach commented Nov 11, 2024

Description

Upgrade to Go1.23.3, to address fatal crash observe in production.

golang/go#69882

Linear Ticket

https://linear.app/rudderstack/issue/PIPE-1723/fix-fatal-error-too-many-concurrent-timer-firings

resolves PIPE-1723

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@lvrach lvrach marked this pull request as ready for review November 11, 2024 08:43
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.29%. Comparing base (4d48f3c) to head (3175448).
Report is 1 commits behind head on release/1.38.x.

Additional details and impacted files
@@               Coverage Diff               @@
##           release/1.38.x    #5283   +/-   ##
===============================================
  Coverage           73.28%   73.29%           
===============================================
  Files                 424      424           
  Lines               59946    59946           
===============================================
+ Hits                43934    43938    +4     
+ Misses              13555    13550    -5     
- Partials             2457     2458    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Sidddddarth Sidddddarth changed the base branch from master to release/1.38.x November 11, 2024 09:07
@Sidddddarth Sidddddarth merged commit cae62c5 into release/1.38.x Nov 11, 2024
63 checks passed
@Sidddddarth Sidddddarth deleted the fix.timer-firings branch November 11, 2024 09:31
This was referenced Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants