fix: close http response body only if there is no error #2447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cisse21
approved these changes
Sep 15, 2022
saurav-malani
approved these changes
Sep 15, 2022
Merged
atzoum
added a commit
that referenced
this pull request
Sep 16, 2022
* fix: close http response body only if there is no error (#2447) * chore: release 1.1.1 (#2448) Co-authored-by: Rudder Bot (server team) <[email protected]>
fracasula
pushed a commit
that referenced
this pull request
Oct 3, 2022
fracasula
added a commit
that referenced
this pull request
Oct 3, 2022
* fix: close http response body only if there is no error (#2447) * exp: test to reproduce * fix: fallback to standar lib json and report * fmt * fix: snowflake identifier issue (#2471) * chore: release 1.1.2 (#2472) * lint * Apply suggestions from code review Co-authored-by: Francesco Casula <[email protected]> * pr fixes * chore: changing log entry * chore: removing unnecessary inits * chore: re-panicking Co-authored-by: Aris Tzoumas <[email protected]> Co-authored-by: Akash Chetty <[email protected]> Co-authored-by: Rudder Bot (server team) <[email protected]> Co-authored-by: Francesco Casula <[email protected]> Co-authored-by: Francesco Casula <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Treating improper (nil) body close
Security