Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release): pull release/3.45.0-SDK-2539 into main #1898

Merged
merged 17 commits into from
Oct 22, 2024

Conversation

devops-github-rudderstack
Copy link
Contributor

👑 An automated PR

This PR is created automatically by the GitHub Actions workflow to merge the release branch into the main branch.

Linear Ticket:
https://linear.app/rudderstack/issue/SDK-2539

MoumitaM and others added 16 commits October 15, 2024 12:33
* refactor: reduce conginitive complexity of the function

* refactor: reduce cognitive complexity of the whole function

* refactor: reduce cognitive complexity of the whole function

* chore: bump size limit
* initialize iubenda consent manager plugin

* implement plugin methods

* fix mapping purposes

* add iubendaConsentManager to ExternalConfig, removed unused imports

* Created iubenda.html

* Update rollup.config.mjs

fixed path typo

* Updates example/v3/iubenda.html to match the new changes in JavaScript SDK v3

* update index.html for iubenda

* update cs config

* delete iubedna file from examples

* add unit tests

* use encodeURIComponent

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* fix typo

* add cookie pattern

* add try and catch

* Apply suggestions from code review

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* remove no longer needed check

* fix getIubendaCookieName function

* revert removed block to match tests

* remove unused logMessage

* remove no longer used "IUBENDA_ACCESS_ERROR"

* pump size limit value

* remove backward unnecessary compatibility block

---------

Co-authored-by: Sai Kumar Battinoju <[email protected]>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
* chore: update code owners for easier release management

* chore: add slash to directories to apply the changes to all

* chore: pass env correctly to npm

* chore: use cross-env

* chore: try direct commit hash

* chore: specify head commit too

* chore: use env now

* chore: move base ref to global env

* chore: check for affected projects

* chore: fix all the workflows

* chore: skip fixing workflows for now

* chore: fix affected issues
saikumarrs
saikumarrs previously approved these changes Oct 21, 2024
Copy link

github-actions bot commented Oct 21, 2024

size-limit report 📦

Name Size (Base) Size (Current) Size Limit Status
Plugins Module Federation Mapping - Legacy - CDN 332 B 332 B (0%) 512 B
Plugins - Legacy - CDN 15.55 KB 15.53 KB (-0.11% ▼) 16 KB
Plugins Module Federation Mapping - Modern - CDN 331 B 331 B (0%) 512 B
Plugins - Modern - CDN 7.2 KB 7.2 KB (0%) 7.5 KB
Common - No bundling 16.12 KB 16.12 KB (0%) 16.5 KB
Cookies Utils - Legacy - NPM (ESM) 1.54 KB 1.54 KB (0%) 2 KB
Cookies Utils - Legacy - NPM (CJS) 1.75 KB 1.75 KB (0%) 2 KB
Cookies Utils - Legacy - NPM (UMD) 1.53 KB 1.53 KB (0%) 2 KB
Cookies Utils - Modern - NPM (ESM) 1.17 KB 1.17 KB (0%) 1.5 KB
Cookies Utils - Modern - NPM (CJS) 1.4 KB 1.4 KB (0%) 1.5 KB
Cookies Utils - Modern - NPM (UMD) 1.16 KB 1.16 KB (0%) 1.5 KB
Load Snippet 758 B 758 B (0%) 1 KB
Core (v1.1) - NPM (ESM) 30.28 KB 30.28 KB (+0.02% ▲) 32 KB
Core (v1.1) - NPM (CJS) 30.56 KB 30.52 KB (-0.14% ▼) 32 KB
Core (v1.1) - NPM (UMD) 30.32 KB 30.31 KB (-0.06% ▼) 32 KB
Core (Content Script - v1.1) - NPM (ESM) 29.8 KB 29.79 KB (-0.02% ▼) 30.5 KB
Core (Content Script - v1.1) - NPM (CJS) 30.08 KB 30.06 KB (-0.09% ▼) 30.5 KB
Core (Content Script - v1.1) - NPM (UMD) 29.86 KB 29.91 KB (+0.17% ▲) 30 KB
Core - Legacy - CDN 47.44 KB 47.87 KB (+0.91% ▲) 48 KB
Core - Modern - CDN 24.25 KB 24.33 KB (+0.33% ▲) 24.5 KB
Core - Legacy - NPM (ESM) 47.28 KB 47.78 KB (+1.06% ▲) 48 KB
Core - Legacy - NPM (CJS) 47.5 KB 47.95 KB (+0.96% ▲) 48 KB
Core - Legacy - NPM (UMD) 47.25 KB 47.72 KB (+1% ▲) 48 KB
Core - Modern - NPM (ESM) 24 KB 24.05 KB (+0.23% ▲) 24.5 KB
Core - Modern - NPM (CJS) 24.21 KB 24.26 KB (+0.2% ▲) 24.5 KB
Core - Modern - NPM (UMD) 24.04 KB 24.08 KB (+0.2% ▲) 24.5 KB
Core (Bundled) - Legacy - NPM (ESM) 47.28 KB 47.78 KB (+1.06% ▲) 48 KB
Core (Bundled) - Legacy - NPM (CJS) 47.54 KB 47.99 KB (+0.94% ▲) 48.5 KB
Core (Bundled) - Legacy - NPM (UMD) 47.25 KB 47.72 KB (+1% ▲) 48 KB
Core (Bundled) - Modern - NPM (ESM) 38.65 KB 38.94 KB (+0.75% ▲) 39 KB
Core (Bundled) - Modern - NPM (CJS) 38.92 KB 39.3 KB (+0.99% ▲) 39.5 KB
Core (Bundled) - Modern - NPM (UMD) 38.67 KB 39.03 KB (+0.95% ▲) 39.5 KB
Core (Content Script) - Legacy - NPM (ESM) 46.75 KB 47.22 KB (+1.01% ▲) 48 KB
Core (Content Script) - Legacy - NPM (CJS) 46.98 KB 47.5 KB (+1.12% ▲) 48 KB
Core (Content Script) - Legacy - NPM (UMD) 46.79 KB 47.28 KB (+1.04% ▲) 47.5 KB
Core (Content Script) - Modern - NPM (ESM) 38.07 KB 38.43 KB (+0.94% ▲) 38.5 KB
Core (Content Script) - Modern - NPM (CJS) 38.38 KB 38.65 KB (+0.7% ▲) 40 KB
Core (Content Script) - Modern - NPM (UMD) 38.11 KB 38.4 KB (+0.77% ▲) 38.5 KB
Service Worker - Legacy - NPM (ESM) 30.6 KB 30.6 KB (-0.01% ▼) 31 KB
Service Worker - Legacy - NPM (CJS) 30.86 KB 30.91 KB (+0.16% ▲) 31 KB
Service Worker - Legacy - NPM (UMD) 30.65 KB 30.64 KB (-0.03% ▼) 31 KB
Service Worker - Modern - NPM (ESM) 25.76 KB 25.75 KB (-0.02% ▼) 26 KB
Service Worker - Modern - NPM (CJS) 26 KB 26 KB (+0.04% ▲) 26.5 KB
Service Worker - Modern - NPM (UMD) 25.75 KB 25.79 KB (+0.13% ▲) 26 KB
All Integrations - Legacy - CDN 94.15 KB 94.15 KB (0%) 95.3 KB
All Integrations - Modern - CDN 89.35 KB 89.35 KB (0%) 91 KB

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 96.87500% with 4 lines in your changes missing coverage. Please review.

Project coverage is 57.24%. Comparing base (3cae743) to head (df7faf7).
Report is 18 commits behind head on main.

Files with missing lines Patch % Lines
...tics-js-plugins/src/iubendaConsentManager/utils.ts 95.91% 1 Missing and 1 partial ⚠️
packages/analytics-js-plugins/src/index.ts 0.00% 1 Missing ⚠️
...uginsManager/federatedModulesBuildPluginImports.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1898      +/-   ##
==========================================
+ Coverage   56.98%   57.24%   +0.25%     
==========================================
  Files         476      480       +4     
  Lines       16256    16363     +107     
  Branches     3239     3282      +43     
==========================================
+ Hits         9264     9367     +103     
+ Misses       5774     5719      -55     
- Partials     1218     1277      +59     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Oct 21, 2024

@MoumitaM MoumitaM merged commit 13b50df into main Oct 22, 2024
14 checks passed
@MoumitaM MoumitaM deleted the release/3.45.0-SDK-2539 branch October 22, 2024 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants