chore: remove leading slash from provided endpoint

rudderlabs · May 21, 2024 · 3492300 · 3492300
1 parent b7c464c
commit 3492300
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/packages/analytics-js/__tests__/components/configManager/validate.test.ts b/packages/analytics-js/__tests__/components/configManager/validate.test.ts
@@ -46,8 +46,12 @@ describe('Config manager util - validate load arguments', () => {
   });
   describe('getDataServiceUrl', () => {
     it('should return dataServiceUrl', () => {
-      const dataServiceUrl = getDataServiceUrl('rsaRequest');
-      expect(dataServiceUrl).toBe('http://test-host.com/rsaRequest');
+      const dataServiceUrl = getDataServiceUrl('endpoint');
+      expect(dataServiceUrl).toBe('http://test-host.com/endpoint');
+    });
+    it('should prepare the dataServiceUrl with endpoint without leading slash', () => {
+      const dataServiceUrl = getDataServiceUrl('/endpoint');
+      expect(dataServiceUrl).toBe('http://test-host.com/endpoint');
     });
   });
 });
diff --git a/packages/analytics-js/src/components/configManager/util/validate.ts b/packages/analytics-js/src/components/configManager/util/validate.ts
@@ -60,7 +60,8 @@ const getTopDomainUrl = (url: string) => {
 
 const getDataServiceUrl = (endpoint: string) => {
   const url = getTopDomainUrl(window.location.href);
-  return `${url}/${endpoint}`;
+  const formattedEndpoint = endpoint.startsWith('/') ? endpoint.substring(1) : endpoint;
+  return `${url}/${formattedEndpoint}`;
 };
 
 export {