Installation failure with new libv8

[bkabrda]

Hi, I've got another problem with installation, here is my scenario:

• I have newest libv8 gem installed.
• I run 'gem install therubyracer'.
• The installation fails with "extconf.rb:15:in <main>': undefined methodinclude_path' for Libv8:Module (NoMethodError)"

The problem is, that therubyracer installs the proper version of libv8, but in extconf, it just requires 'libv8', so the newer gets in play - and the newer one doesn not have the include_path, but rather libv8_include_path (similarly for library_path). I already mentioned this in issue #148, which is in fact two problems - one that I sent pull request #165 for and this one.

Would it be possible to update therubyracer to use the newest libv8 (and perhaps, to maintain backwards compatibility by being able to use both include_path and libv8_include_path)?

I will send a pull request if you want.
Thanks!

[cowboyd]

On Jun 15, 2012, at 5:31 AM, Bohuslav Kabrda wrote:

Hi, I've got another problem with installation, here is my scenario:

• I have newest libv8 gem installed.
• I run 'gem install therubyracer'.
• The installation fails with "extconf.rb:15:in <main>': undefined methodinclude_path' for Libv8:Module (NoMethodError)"

The problem is, that therubyracer installs the proper version of libv8, but in extconf, it just requires 'libv8', so the newer gets in play - and the newer one doesn not have the include_path, but rather libv8_include_path (similarly for library_path). I already mentioned this in issue #148, which is in fact two problems - one that I sent pull request #165 for and this one.

Would it be possible to update therubyracer to use the newest libv8 (and perhaps, to maintain backwards compatibility by being able to use both include_path and libv8_include_path)?

I am in the process of doing just that. You may even be able to check it out from the development branch: internal-rewrite.

I will send a pull request if you want.
Thanks!

---

Reply to this email directly or view it on GitHub:
#166

[cowboyd]

these changes have just landed on master

[bkabrda]

Looks great, thanks.