Skip to content
This repository has been archived by the owner on Jul 31, 2023. It is now read-only.

Run linters from workspace root #718

Closed
wants to merge 1 commit into from

Conversation

FooBarWidget
Copy link
Contributor

@FooBarWidget FooBarWidget commented Mar 25, 2021

Fixes #717.

  • The build passes
  • TSLint is mostly happy — It was already unhappy. This PR doesn't make it more unhappy.
  • Prettier has been run — Not possible because TSLint was already unhappy through no fault of this PR.

@codecov
Copy link

codecov bot commented Mar 25, 2021

Codecov Report

Merging #718 (46ee01c) into master (7b5b602) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #718   +/-   ##
======================================
  Coverage    5.08%   5.08%           
======================================
  Files          10      10           
  Lines         118     118           
  Branches       20      20           
======================================
  Hits            6       6           
  Misses        112     112           
Flag Coverage Δ
language_server_ruby 5.08% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/language-server-ruby/src/Linter.ts 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b5b602...46ee01c. Read the comment docs.

@FooBarWidget FooBarWidget changed the title fix(language-server-ruby): run linters from workspace root Run linters from workspace root Mar 25, 2021
@github-actions
Copy link

This PR has not had activity for 30 days. It will be automatically closed in 7 days.

@github-actions github-actions bot added the stale label Apr 25, 2021
@FooBarWidget
Copy link
Contributor Author

Closing this PR because of #717 (comment)

Running linters not from the workspace root is in fact intentional.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Linters run from file's directory, not from workspace root
1 participant