This repository has been archived by the owner on Jul 31, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces support for interpolating the
workspaceRoot
into the linter path and running the linter via bundler. This should resolve #188 and #187.The linter path will be resolved in the following order:
${workspaceRoot}
will be interpolated.This also makes a change to the directory in which the linter is executed. Before it would execute in the project root and fall back to the target file's working directory. Now it does the opposite. This was a requirement to support #188. This has the potential to break people who have set the linter path to be relative to the workspace root. The upgrade path would be to use the variable interpolation instead. See here