Skip to content
This repository has been archived by the owner on Jul 31, 2023. It is now read-only.

Add workspaceRoot and bundler support #232

Merged
merged 1 commit into from
Jan 25, 2018
Merged

Add workspaceRoot and bundler support #232

merged 1 commit into from
Jan 25, 2018

Conversation

wingrunr21
Copy link
Collaborator

@wingrunr21 wingrunr21 commented Dec 16, 2017

This PR introduces support for interpolating the workspaceRoot into the linter path and running the linter via bundler. This should resolve #188 and #187.

The linter path will be resolved in the following order:

  1. If a path is set on the linter, that will be used. ${workspaceRoot} will be interpolated.
  2. It will attempt to find the linter name via bundler
  3. It will call the linter name (eg the linter is installed globally)

This also makes a change to the directory in which the linter is executed. Before it would execute in the project root and fall back to the target file's working directory. Now it does the opposite. This was a requirement to support #188. This has the potential to break people who have set the linter path to be relative to the workspace root. The upgrade path would be to use the variable interpolation instead. See here

@wingrunr21
Copy link
Collaborator Author

ping @rebornix

@wingrunr21 wingrunr21 closed this Jan 22, 2018
@wingrunr21 wingrunr21 deleted the workspaceroot_support branch January 22, 2018 00:26
@wingrunr21 wingrunr21 restored the workspaceroot_support branch January 25, 2018 01:48
@wingrunr21 wingrunr21 reopened this Jan 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bundler is not taken into account for linters
2 participants