Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the --rdoc and --ri options from install/update #2354

Merged
1 commit merged into from
Sep 26, 2018

Conversation

colby-swandale
Copy link
Member

The --rdoc and --ri options have been marked as deprecated for a while now and with the release of RubyGems 3 looming - it seems like a good idea to get rid of them now.


Tasks:

  • Describe the problem / feature
  • Write tests
  • Write code to solve the problem
  • Get code review from coworkers / friends

I will abide by the code of conduct.

@hsbt
Copy link
Member

hsbt commented Jul 12, 2018

@bundlerbot r+

@bundlerbot
Copy link
Collaborator

📌 Commit 1f00622 has been approved by hsbt

@bundlerbot
Copy link
Collaborator

⌛ Testing commit 1f00622 with merge 6752714...

bundlerbot added a commit that referenced this pull request Jul 12, 2018
…ns, r=hsbt

Remove the --rdoc and --ri options from install/update

The `--rdoc` and `--ri` options have been marked as deprecated for a while now and with the release of RubyGems 3 looming - it seems like a good idea to get rid of them now.
______________

# Tasks:

- [ ] Describe the problem / feature
- [ ] Write tests
- [ ] Write code to solve the problem
- [ ] Get code review from coworkers / friends

I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md).
@bundlerbot
Copy link
Collaborator

💔 Test failed - status-travis

@hsbt
Copy link
Member

hsbt commented Jul 12, 2018

Fixed broken specs: rubygems/bundler#6624

@colby-swandale colby-swandale force-pushed the colby/remove-install-update-rdoc-options branch from 1f00622 to 6cf40e6 Compare July 12, 2018 09:41
bundlerbot added a commit to rubygems/bundler that referenced this pull request Jul 12, 2018
Prefer to use `--no-document` option in spec

### What was the end-user problem that led to this PR?

RubyGems will remove `--no-ri` and `--no-rdoc` options at RubyGems 3.0. But bundler spec is also broken when removing them.

* rubygems/rubygems#2354
* https://travis-ci.org/rubygems/rubygems/jobs/402911887

### What is your fix for the problem, implemented in this PR?

To use --no-document option after RubyGems 2.0.
@duckinator
Copy link
Member

@bundlerbot retry

@hsbt
Copy link
Member

hsbt commented Jul 20, 2018

rubygems/bundler#6624 was not contained in bundler-1.16.3. We try again to merge this after releasing bundler-1.16.4 or 1.17.0

colby-swandale pushed a commit to rubygems/bundler that referenced this pull request Aug 16, 2018
Prefer to use `--no-document` option in spec

### What was the end-user problem that led to this PR?

RubyGems will remove `--no-ri` and `--no-rdoc` options at RubyGems 3.0. But bundler spec is also broken when removing them.

* rubygems/rubygems#2354
* https://travis-ci.org/rubygems/rubygems/jobs/402911887

### What is your fix for the problem, implemented in this PR?

To use --no-document option after RubyGems 2.0.

(cherry picked from commit 8d53c82)
@colby-swandale
Copy link
Member Author

@bundlerbot retry

@colby-swandale
Copy link
Member Author

@bundlerbot r+

ghost pushed a commit that referenced this pull request Sep 26, 2018
2354: Remove the --rdoc and --ri options from install/update r=colby-swandale a=colby-swandale

The `--rdoc` and `--ri` options have been marked as deprecated for a while now and with the release of RubyGems 3 looming - it seems like a good idea to get rid of them now.
______________

# Tasks:

- [ ] Describe the problem / feature
- [ ] Write tests
- [ ] Write code to solve the problem
- [ ] Get code review from coworkers / friends

I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md).


Co-authored-by: Colby Swandale <[email protected]>
@ghost
Copy link

ghost commented Sep 26, 2018

Build succeeded

@ghost ghost merged commit 6cf40e6 into master Sep 26, 2018
@colby-swandale colby-swandale deleted the colby/remove-install-update-rdoc-options branch September 26, 2018 21:45
tigefa4u pushed a commit to tigefa4u/gitlabhq that referenced this pull request Dec 31, 2018
`--no-rdoc` and `--no-ri` have been deprecated since RubyGems 2.0:
https://github.com/rubygems/rubygems/blob/v2.0.0/History.txt#L43

They were finally removed in a recent release:
rubygems/rubygems#2354
tigefa4u pushed a commit to tigefa4u/gitlabhq that referenced this pull request Dec 31, 2018
`--no-rdoc` and `--no-ri` have been deprecated since RubyGems 2.0:
https://github.com/rubygems/rubygems/blob/v2.0.0/History.txt#L43

They were finally removed in a recent release:
rubygems/rubygems#2354
tigefa4u pushed a commit to tigefa4u/gitlabhq that referenced this pull request Dec 31, 2018
`--no-rdoc` and `--no-ri` have been deprecated since RubyGems 2.0:
https://github.com/rubygems/rubygems/blob/v2.0.0/History.txt#L43

They were finally removed in a recent release:
rubygems/rubygems#2354
tigefa4u pushed a commit to tigefa4u/gitlabhq that referenced this pull request Dec 31, 2018
`--no-rdoc` and `--no-ri` have been deprecated since RubyGems 2.0:
https://github.com/rubygems/rubygems/blob/v2.0.0/History.txt#L43

They were finally removed in a recent release:
rubygems/rubygems#2354
maxlazio pushed a commit to gitlabhq/gitlabhq that referenced this pull request Jan 1, 2019
`--no-rdoc` and `--no-ri` have been deprecated since RubyGems 2.0:
https://github.com/rubygems/rubygems/blob/v2.0.0/History.txt#L43

They were finally removed in a recent release:
rubygems/rubygems#2354
kevin-j-m added a commit to TheGnarCo/gnarails that referenced this pull request Jan 2, 2019
Rubygems 3.0.0 removed the --rdoc and --ri options from install and
update, which were deprecated previously. This was removed in the
following pull request: rubygems/rubygems#2354.

This removes the use of these options in favor of the new `--no-document`
option. The documentation states that this option will,
"disable documentation generation".
Copy link

@forrestc forrestc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

dhui added a commit to golang-migrate/migrate that referenced this pull request Jan 4, 2019
    - `gem install` no longer recognizes the `--no-ri` and `--no-rdoc` options. Use `--no-document` instead.
    - References:
        - rubygems/rubygems#2354
        - rubygems/bundler#6624
danbao added a commit to ringcentral-docker/rcweb-builder that referenced this pull request Jan 4, 2019
adamcrown added a commit to codenoble/chef-puma that referenced this pull request Jul 9, 2019
They've been replaced by `--no-document` but for better compatibility,
I think it's best to have none of these options set at all, as the
defaults should be fine.

See rubygems/rubygems#2354
altendky added a commit to python-desert/desert that referenced this pull request Jul 28, 2020
jmeattle added a commit to shareaholic/chef-puma that referenced this pull request Sep 27, 2022
* Add phased restart to monit

* fix simple typo

* Remove the now invalid calls to --no-ri and --no-rdoc

They've been replaced by `--no-document` but for better compatibility,
I think it's best to have none of these options set at all, as the
defaults should be fine.

See rubygems/rubygems#2354

* Bump nokogiri from 1.6.7.1 to 1.10.8

Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.6.7.1 to 1.10.8.
- [Release notes](https://github.com/sparklemotion/nokogiri/releases)
- [Changelog](https://github.com/sparklemotion/nokogiri/blob/master/CHANGELOG.md)
- [Commits](sparklemotion/nokogiri@v1.6.7.1...v1.10.8)

Signed-off-by: dependabot[bot] <[email protected]>

* Bump rack from 1.6.4 to 2.2.3

Bumps [rack](https://github.com/rack/rack) from 1.6.4 to 2.2.3.
- [Release notes](https://github.com/rack/rack/releases)
- [Changelog](https://github.com/rack/rack/blob/master/CHANGELOG.md)
- [Commits](rack/rack@1.6.4...2.2.3)

Signed-off-by: dependabot[bot] <[email protected]>

* Bump json from 1.8.3 to 2.3.1

Bumps [json](https://github.com/flori/json) from 1.8.3 to 2.3.1.
- [Release notes](https://github.com/flori/json/releases)
- [Changelog](https://github.com/flori/json/blob/master/CHANGES.md)
- [Commits](ruby/json@v1.8.3...v2.3.1)

Signed-off-by: dependabot[bot] <[email protected]>

* Bump rake from 10.4.2 to 13.0.3

Bumps [rake](https://github.com/ruby/rake) from 10.4.2 to 13.0.3.
- [Release notes](https://github.com/ruby/rake/releases)
- [Changelog](https://github.com/ruby/rake/blob/master/History.rdoc)
- [Commits](ruby/rake@v10.4.2...v13.0.3)

Signed-off-by: dependabot[bot] <[email protected]>

* Bump ffi from 1.9.10 to 1.14.2

Bumps [ffi](https://github.com/ffi/ffi) from 1.9.10 to 1.14.2.
- [Release notes](https://github.com/ffi/ffi/releases)
- [Changelog](https://github.com/ffi/ffi/blob/master/CHANGELOG.md)
- [Commits](https://github.com/ffi/ffi/commits)

Signed-off-by: dependabot[bot] <[email protected]>

* Bump yajl-ruby from 1.2.1 to 1.4.1

Bumps [yajl-ruby](https://github.com/brianmario/yajl-ruby) from 1.2.1 to 1.4.1.
- [Release notes](https://github.com/brianmario/yajl-ruby/releases)
- [Changelog](https://github.com/brianmario/yajl-ruby/blob/master/CHANGELOG.md)
- [Commits](brianmario/yajl-ruby@1.2.1...1.4.1)

Signed-off-by: dependabot[bot] <[email protected]>

* Bump nokogiri from 1.10.8 to 1.12.5

Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.10.8 to 1.12.5.
- [Release notes](https://github.com/sparklemotion/nokogiri/releases)
- [Changelog](https://github.com/sparklemotion/nokogiri/blob/main/CHANGELOG.md)
- [Commits](sparklemotion/nokogiri@v1.10.8...v1.12.5)

---
updated-dependencies:
- dependency-name: nokogiri
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Nigel Sheridan-Smith <[email protected]>
Co-authored-by: lpmi-13 <[email protected]>
Co-authored-by: Adam Crownoble <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Yousef Ourabi <[email protected]>
FPiety0521 pushed a commit to FPiety0521/Golang-SQL that referenced this pull request May 24, 2023
    - `gem install` no longer recognizes the `--no-ri` and `--no-rdoc` options. Use `--no-document` instead.
    - References:
        - rubygems/rubygems#2354
        - rubygems/bundler#6624
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants