Remove the --rdoc and --ri options from install/update #2354

colby-swandale · 2018-07-10T10:58:06Z

The --rdoc and --ri options have been marked as deprecated for a while now and with the release of RubyGems 3 looming - it seems like a good idea to get rid of them now.

Tasks:

Describe the problem / feature
Write tests
Write code to solve the problem
Get code review from coworkers / friends

I will abide by the code of conduct.

hsbt · 2018-07-12T00:22:27Z

@bundlerbot r+

bundlerbot · 2018-07-12T00:22:28Z

📌 Commit 1f00622 has been approved by hsbt

bundlerbot · 2018-07-12T00:22:32Z

⌛ Testing commit 1f00622 with merge 6752714...

…ns, r=hsbt Remove the --rdoc and --ri options from install/update The `--rdoc` and `--ri` options have been marked as deprecated for a while now and with the release of RubyGems 3 looming - it seems like a good idea to get rid of them now. ______________ # Tasks: - [ ] Describe the problem / feature - [ ] Write tests - [ ] Write code to solve the problem - [ ] Get code review from coworkers / friends I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md).

bundlerbot · 2018-07-12T00:26:23Z

💔 Test failed - status-travis

hsbt · 2018-07-12T03:16:22Z

Fixed broken specs: rubygems/bundler#6624

Prefer to use `--no-document` option in spec ### What was the end-user problem that led to this PR? RubyGems will remove `--no-ri` and `--no-rdoc` options at RubyGems 3.0. But bundler spec is also broken when removing them. * rubygems/rubygems#2354 * https://travis-ci.org/rubygems/rubygems/jobs/402911887 ### What is your fix for the problem, implemented in this PR? To use --no-document option after RubyGems 2.0.

duckinator · 2018-07-20T22:21:08Z

@bundlerbot retry

hsbt · 2018-07-20T22:53:17Z

rubygems/bundler#6624 was not contained in bundler-1.16.3. We try again to merge this after releasing bundler-1.16.4 or 1.17.0

Prefer to use `--no-document` option in spec ### What was the end-user problem that led to this PR? RubyGems will remove `--no-ri` and `--no-rdoc` options at RubyGems 3.0. But bundler spec is also broken when removing them. * rubygems/rubygems#2354 * https://travis-ci.org/rubygems/rubygems/jobs/402911887 ### What is your fix for the problem, implemented in this PR? To use --no-document option after RubyGems 2.0. (cherry picked from commit 8d53c82)

colby-swandale · 2018-09-23T07:32:10Z

@bundlerbot retry

colby-swandale · 2018-09-26T13:41:15Z

@bundlerbot r+

2354: Remove the --rdoc and --ri options from install/update r=colby-swandale a=colby-swandale The `--rdoc` and `--ri` options have been marked as deprecated for a while now and with the release of RubyGems 3 looming - it seems like a good idea to get rid of them now. ______________ # Tasks: - [ ] Describe the problem / feature - [ ] Write tests - [ ] Write code to solve the problem - [ ] Get code review from coworkers / friends I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md). Co-authored-by: Colby Swandale <[email protected]>

ghost · 2018-09-26T14:07:04Z

Build succeeded

continuous-integration/travis-ci/push

`--no-rdoc` and `--no-ri` have been deprecated since RubyGems 2.0: https://github.com/rubygems/rubygems/blob/v2.0.0/History.txt#L43 They were finally removed in a recent release: rubygems/rubygems#2354

Rubygems 3.0.0 removed the --rdoc and --ri options from install and update, which were deprecated previously. This was removed in the following pull request: rubygems/rubygems#2354. This removes the use of these options in favor of the new `--no-document` option. The documentation states that this option will, "disable documentation generation".

forrestc

LGTM 👍

- `gem install` no longer recognizes the `--no-ri` and `--no-rdoc` options. Use `--no-document` instead. - References: - rubygems/rubygems#2354 - rubygems/bundler#6624

…ems#2354

They've been replaced by `--no-document` but for better compatibility, I think it's best to have none of these options set at all, as the defaults should be fine. See rubygems/rubygems#2354

rubygems/rubygems#2354 Change noticed while working #103.

* Add phased restart to monit * fix simple typo * Remove the now invalid calls to --no-ri and --no-rdoc They've been replaced by `--no-document` but for better compatibility, I think it's best to have none of these options set at all, as the defaults should be fine. See rubygems/rubygems#2354 * Bump nokogiri from 1.6.7.1 to 1.10.8 Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.6.7.1 to 1.10.8. - [Release notes](https://github.com/sparklemotion/nokogiri/releases) - [Changelog](https://github.com/sparklemotion/nokogiri/blob/master/CHANGELOG.md) - [Commits](sparklemotion/nokogiri@v1.6.7.1...v1.10.8) Signed-off-by: dependabot[bot] <[email protected]> * Bump rack from 1.6.4 to 2.2.3 Bumps [rack](https://github.com/rack/rack) from 1.6.4 to 2.2.3. - [Release notes](https://github.com/rack/rack/releases) - [Changelog](https://github.com/rack/rack/blob/master/CHANGELOG.md) - [Commits](rack/rack@1.6.4...2.2.3) Signed-off-by: dependabot[bot] <[email protected]> * Bump json from 1.8.3 to 2.3.1 Bumps [json](https://github.com/flori/json) from 1.8.3 to 2.3.1. - [Release notes](https://github.com/flori/json/releases) - [Changelog](https://github.com/flori/json/blob/master/CHANGES.md) - [Commits](ruby/json@v1.8.3...v2.3.1) Signed-off-by: dependabot[bot] <[email protected]> * Bump rake from 10.4.2 to 13.0.3 Bumps [rake](https://github.com/ruby/rake) from 10.4.2 to 13.0.3. - [Release notes](https://github.com/ruby/rake/releases) - [Changelog](https://github.com/ruby/rake/blob/master/History.rdoc) - [Commits](ruby/rake@v10.4.2...v13.0.3) Signed-off-by: dependabot[bot] <[email protected]> * Bump ffi from 1.9.10 to 1.14.2 Bumps [ffi](https://github.com/ffi/ffi) from 1.9.10 to 1.14.2. - [Release notes](https://github.com/ffi/ffi/releases) - [Changelog](https://github.com/ffi/ffi/blob/master/CHANGELOG.md) - [Commits](https://github.com/ffi/ffi/commits) Signed-off-by: dependabot[bot] <[email protected]> * Bump yajl-ruby from 1.2.1 to 1.4.1 Bumps [yajl-ruby](https://github.com/brianmario/yajl-ruby) from 1.2.1 to 1.4.1. - [Release notes](https://github.com/brianmario/yajl-ruby/releases) - [Changelog](https://github.com/brianmario/yajl-ruby/blob/master/CHANGELOG.md) - [Commits](brianmario/yajl-ruby@1.2.1...1.4.1) Signed-off-by: dependabot[bot] <[email protected]> * Bump nokogiri from 1.10.8 to 1.12.5 Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.10.8 to 1.12.5. - [Release notes](https://github.com/sparklemotion/nokogiri/releases) - [Changelog](https://github.com/sparklemotion/nokogiri/blob/main/CHANGELOG.md) - [Commits](sparklemotion/nokogiri@v1.10.8...v1.12.5) --- updated-dependencies: - dependency-name: nokogiri dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Nigel Sheridan-Smith <[email protected]> Co-authored-by: lpmi-13 <[email protected]> Co-authored-by: Adam Crownoble <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Yousef Ourabi <[email protected]>

- `gem install` no longer recognizes the `--no-ri` and `--no-rdoc` options. Use `--no-document` instead. - References: - rubygems/rubygems#2354 - rubygems/bundler#6624

bronzdoc added the status: triage label Jul 10, 2018

colby-swandale requested a review from hsbt July 10, 2018 10:59

colby-swandale added the rubygems: breaking change label Jul 10, 2018

deivid-rodriguez approved these changes Jul 10, 2018

View reviewed changes

segiddins approved these changes Jul 11, 2018

View reviewed changes

hsbt approved these changes Jul 12, 2018

View reviewed changes

hsbt mentioned this pull request Jul 12, 2018

Prefer to use --no-document option in spec rubygems/bundler#6624

Merged

Remove the --rdoc and --ri options from install/update

6cf40e6

colby-swandale force-pushed the colby/remove-install-update-rdoc-options branch from 1f00622 to 6cf40e6 Compare July 12, 2018 09:41

ghost merged commit 6cf40e6 into master Sep 26, 2018

bronzdoc removed the status: triage label Sep 26, 2018

colby-swandale deleted the colby/remove-install-update-rdoc-options branch September 26, 2018 21:45

tnir mentioned this pull request Jan 1, 2019

Replace deprecated options with newly introduced options for gem completion fish-shell/fish-shell#5459

Merged

3 tasks

kevin-j-m mentioned this pull request Jan 2, 2019

Remove Usage of --rdoc and --ri TheGnarCo/gnarails#130

Merged

forrestc reviewed Jan 2, 2019

View reviewed changes

dhui added a commit to golang-migrate/migrate that referenced this pull request Jan 4, 2019

Fix broken build

600f2ed

- `gem install` no longer recognizes the `--no-ri` and `--no-rdoc` options. Use `--no-document` instead. - References: - rubygems/rubygems#2354 - rubygems/bundler#6624

danbao added a commit to ringcentral-docker/rcweb-builder that referenced this pull request Jan 4, 2019

fix(Dockerfile): Remove --no-ri and --no-rdoc options: rubygems/rubyg…

25c37bf

…ems#2354

claui mentioned this pull request Jan 8, 2019

Fix deprecated Rubygems options Homebrew/brew#5503

Merged

6 tasks

douglascayers mentioned this pull request Jan 26, 2019

osx installation error - readme needs updating travis-ci/travis.rb#646

Open

garritfra mentioned this pull request Feb 13, 2019

Fix broken installation instructions travis-ci/travis.rb#656

Closed

alexventuraio mentioned this pull request Apr 30, 2019

Update the new command to install Rails without documentation. onemonth/install_rails#39

Merged

adamcrown mentioned this pull request Jul 9, 2019

Fix invalid option: --no-ri yourabi/chef-puma#23

Merged

php-coder mentioned this pull request Jun 28, 2020

gem install fails with invalid option: --no-ri php-coder/mystamps#1453

Closed

andreoss mentioned this pull request Jun 29, 2020

Update rultor configuration jcabi/jcabi-matchers#42

Closed

altendky added a commit to python-desert/desert that referenced this pull request Jul 28, 2020

Update gem options in Travis build

95570f5

rubygems/rubygems#2354 Change noticed while working #103.

altendky mentioned this pull request Jul 28, 2020

Update gem options in Travis build python-desert/desert#104

Merged

FPiety0521 pushed a commit to FPiety0521/Golang-SQL that referenced this pull request May 24, 2023

Fix broken build

9c83d38

- `gem install` no longer recognizes the `--no-ri` and `--no-rdoc` options. Use `--no-document` instead. - References: - rubygems/rubygems#2354 - rubygems/bundler#6624

artemgavrilov mentioned this pull request Jul 10, 2024

Replace deprecated '--no-rdoc --no-ri' flags with '--no-document' guedes/pgxn-utils#53

Open

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove the --rdoc and --ri options from install/update #2354

Remove the --rdoc and --ri options from install/update #2354

colby-swandale commented Jul 10, 2018

hsbt commented Jul 12, 2018

bundlerbot commented Jul 12, 2018

bundlerbot commented Jul 12, 2018

bundlerbot commented Jul 12, 2018

hsbt commented Jul 12, 2018

duckinator commented Jul 20, 2018

hsbt commented Jul 20, 2018

colby-swandale commented Sep 23, 2018

colby-swandale commented Sep 26, 2018

ghost commented Sep 26, 2018

forrestc left a comment •

edited

Loading

Remove the --rdoc and --ri options from install/update #2354

Remove the --rdoc and --ri options from install/update #2354

Conversation

colby-swandale commented Jul 10, 2018

Tasks:

hsbt commented Jul 12, 2018

bundlerbot commented Jul 12, 2018

bundlerbot commented Jul 12, 2018

bundlerbot commented Jul 12, 2018

hsbt commented Jul 12, 2018

duckinator commented Jul 20, 2018

hsbt commented Jul 20, 2018

colby-swandale commented Sep 23, 2018

colby-swandale commented Sep 26, 2018

ghost commented Sep 26, 2018

Build succeeded

forrestc left a comment • edited Loading

Choose a reason for hiding this comment

forrestc left a comment •

edited

Loading