This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
[2.0] [DSL] Remove default git sources on 2.0 #5820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
☔ The latest upstream changes (presumably #5782) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Rebased |
segiddins
force-pushed
the
seg-no-default-git-sources
branch
from
f3c7fa2 to
5d257f1
Compare
|
@bundlerbot r+ |
|
📌 Commit 5d257f1 has been approved by |
bundlerbot
added a commit
that referenced
this pull request
Jun 28, 2017
[2.0] [DSL] Remove default git sources on 2.0 ### What was the end-user problem that led to this PR? The problem was the default git source shortcuts have been deprecated, but still existed in 2.0. ### Was was your diagnosis of the problem? My diagnosis was we needed to avoid adding them in 2.0. ### What is your fix for the problem, implemented in this PR? My fix is to introduce a feature flag, which when enabled will stop adding the sources to the DSL, and additionally will disable the `github` DSL method.
|
☀️ Test successful - status-travis |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user problem that led to this PR?
The problem was the default git source shortcuts have been deprecated, but still existed in 2.0.
Was was your diagnosis of the problem?
My diagnosis was we needed to avoid adding them in 2.0.
What is your fix for the problem, implemented in this PR?
My fix is to introduce a feature flag, which when enabled will stop adding the sources to the DSL, and additionally will disable the
githubDSL method.