This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
Summarize the number of using gems #3872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -105,6 +105,7 @@ def run | |||
| Installer.install(Bundler.root, definition, options) | |||
| Bundler.load.cache if Bundler.app_cache.exist? && options["cache"] && !Bundler.settings[:frozen] | |||
|
|
|||
| Bundler.ui.confirm "Using #{Installer.using_gems.size} already installed gems" if Installer.using_gems? | |||
There was a problem hiding this comment.
just use Installer.using_gems.size > 0?
hbd225
force-pushed
the
hbd225/summarize-all-the-using-gems
branch
from
220c5ef to
4698ca6
Compare
|
👍 |
hbd225
force-pushed
the
hbd225/summarize-all-the-using-gems
branch
from
4698ca6 to
0fa607d
Compare
|
@homu r+ |
|
📌 Commit 0fa607d has been approved by |
homu
added a commit
that referenced
this pull request
Jul 29, 2015
…ndirect Summarize the number of using gems For this issue rubygems/bundler-features#33 Thanks for making great gem :)
|
☀️ Test successful - status |
bundlerbot
added a commit
that referenced
this pull request
Jul 5, 2017
[2.0] Suppress `Using …` messages during installation when a version has not changed ### What was the end-user problem that led to this PR? The problem was that `bundle install` output can get very verbose, even when Bundler is not doing anything. See rubygems/bundler-features#33. ### Was was your diagnosis of the problem? My diagnosis was that bundler was printing a bunch of `Using name (version)` messages, even when we were already using that gem at the same version. ### What is your fix for the problem, implemented in this PR? My fix is to introduce a feature flag (enabled by default on 2.0), that will only print those extra `Using` messages when `--verbose` is passed, and will continue to print them when there was an old version we can tell users about. Note that we still print a message when installing a gem for the first time. ### Why did you choose this fix out of the possible options? I chose this fix because it was essentially what had been done in #3872, and allows for easy feature-flagging.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For this issue rubygems/bundler-features#33
Thanks for making great gem :)