Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix HTML Escape String Comparison in Test supervisor_datatable_spec #… #2825

Merged
merged 1 commit into from
Oct 23, 2021
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions spec/datatables/supervisor_datatable_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -37,12 +37,13 @@

context "when both" do
let(:additional_filters) { {active: %w[false true]} }
let!(:inactive_supervisor) { create(:supervisor, casa_org: org, active: true, display_name: "Neil O'Reilly") }

it "brings only all supervisors", :aggregate_failures do
expect(subject[:recordsTotal]).to eq(2)
expect(subject[:recordsFiltered]).to eq(2)
expect(subject[:data].map { |d| d[:display_name] }).to include(active_supervisor.display_name)
expect(subject[:data].map { |d| d[:display_name] }).to include(inactive_supervisor.display_name)
expect(subject[:data].map { |d| d[:display_name] }).to include(CGI.escapeHTML(active_supervisor.display_name))
expect(subject[:data].map { |d| d[:display_name] }).to include(CGI.escapeHTML(inactive_supervisor.display_name))
end
end

Expand Down