Get tests running with frozen string literals. #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! |
|
No worries, thanks for merging :) |
|
Specs on 2.4 fail due to RedCloth not supporting immutable strings. |
|
Will be fixed in the next version; sorry for not releasing sooner. |
|
Support for immutable strings has been merged in RedCloth, so that's one step toward making the specs succeed on 2.4: jgarber/redcloth#38 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes ensure that all string literals can be frozen (as per the optional feature in MRI 2.3 and onwards).
I would recommend adding the following to your .travis.yml file to ensure regressions aren't introduced:
This will add the flag when the tests are run on MRI 2.4 or newer (while the feature was introduced in 2.3, it doesn't seem to work reliably until 2.4). Note that to get the test suite passing in that situation, you'll need the latest
test-unitrelease (3.2.5), because that's now also frozen-string-literal compatible.