Send correct inputType when typing #244
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When typing in an input field, the browser usually sends an input event with a specific
inputType
, e.g."insertText"
when adding characters,"deleteContentBackward"
when backspacing, among others.When using
set
orfill_in
on a field, Cuprite is currently triggering the event in a way that leavesinputType
asundefined
, which is (unfortunately) what Chrome actually sends on autocompletion. The mostly correct way to trigger this event here should be with"insertText"
.