Remove hack to prevent years < 1970 in DateTime #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Time can handle dates before epoch perfectly fine. The test here is probably something from ancient times and breaks stuff these days without reason.
|
And for the rest of the world: If you ever feel the need to include this kind of workarounds in your code, please add a unit test to see if the other object (outside of your reach) fails when trying to use the invalid range. That way, if the limitation is ever lifted upstream, you don't end up with outdated workarounds. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Time can handle dates before epoch perfectly fine. The test here is
probably something from ancient times and breaks stuff these days
without reason.