Remove assert matching stderr output in test_sni.

[jackorp]

test_sni should be testing SNI use, it doesn't need to
check for specific stderr output which isn't shown by default.

The test test_sni in test_https.rb file checks stderr output for
information about primes being generated.
Since commit jackorp@6cb9bf6 the output is only
written if $VERBOSE is true. This happens when --verbose is provided
to the Ruby run arguments, or when the tests are ran via rake.

$stderr is still caught, but discarded to not pollute test run output.

---

Ran into this in Fedora when updating the gem. Since we do not use rake to cut down on dependencies in package buildroot, $VERBOSE isn't set, I assume rake at some point sets the variable to true. However, I believe that if there is an assert relying on a specific value of $VERBOSE it should be set for the duration it is needed in the test itself.

[jeremyevans]

I think it would be better to remove this line instead:

assert_match(/\A([.+*]+\n)+\z/, stderr_buffer.string)

test_sni should be testing SNI use (and it does), it doesn't need to check for specific stderr output which isn't shown by default.

[jackorp]

Sounds good, I have removed the line instead. I left catching the stderr in but now it just gets discarded, in order to not pollute test run output should $VERBOSE be true.