Remove special handling of chilled strings #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 30, 2024
eregon
reviewed
May 30, 2024
[Feature #20205] Followup: ruby#94 They no longer need to be special cases. If StringIO end up mutating a chilled string, a warning will be emitted.
casperisfine
force-pushed
the
revert-chilled-strings
branch
from
06ad5cf
to
d38f5e5
Compare
|
This looks like a clear cleanup so I'll merge (I think no need for more reviews before). |
|
Could you also remove |
casperisfine
pushed a commit
to Shopify/stringio
that referenced
this pull request
May 31, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Feature #20205]
Followup: #94
They no longer need to be special cases. If StringIO end up mutating a chilled string, a warning will be emitted.