Add specs for Date#yday and DateTime#yday #1172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrykonchin
approved these changes
Jun 29, 2024
shared/time/yday.rb
Outdated
| @@ -0,0 +1,13 @@ | |||
| describe :yday_date, shared: true do | |||
There was a problem hiding this comment.
It's a common convention to use the following format <class>_<method>, so it could be time_yday.
By using the shared specs of Time#yday
Again by using the shared specs of Time#yday
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is done by converting the existing specs for
Time#ydayinto a shared spec that can be used by the other two classes. An additional spec to cover leap years has been added.