Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add specs for String#to_c #1034

Merged
merged 1 commit into from
May 18, 2023
Merged

Add specs for String#to_c #1034

merged 1 commit into from
May 18, 2023

Conversation

AI-Mozi
Copy link
Contributor

@AI-Mozi AI-Mozi commented May 18, 2023

#1016
[Bug #19087]

String#to_c currently treat a sequence of underscores as an end of Complex
string.

@AI-Mozi AI-Mozi force-pushed the add_specs_for_string_to_c branch from 89b3a33 to a54627f Compare May 18, 2023 06:43
@AI-Mozi AI-Mozi marked this pull request as ready for review May 18, 2023 08:15
andrykonchin
andrykonchin approved these changes May 18, 2023
View reviewed changes
core/string/to_c_spec.rb Outdated Show resolved Hide resolved
core/string/to_c_spec.rb Show resolved Hide resolved
@AI-Mozi AI-Mozi force-pushed the add_specs_for_string_to_c branch from a54627f to 03f3e6a Compare May 18, 2023 10:45
@andrykonchin
Copy link
Member

Thank you!

@andrykonchin andrykonchin merged commit 0006d19 into ruby:master May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrykonchin andrykonchin andrykonchin approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AI-Mozi @andrykonchin