Add Random::Formatter#phrase #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nobu
force-pushed
the
random-phrase
branch
2 times, most recently
from
ca1f77d
to
30b7397
Compare
olleolleolle
reviewed
Dec 6, 2021
Co-authored-by: Olle Jonsson <[email protected]>
| PUNCT = %w[! - + / . ^ ~].freeze | ||
|
|
||
| # Default excluded characters for #phrase | ||
| EXCLUDE = %w"0 O o 1 l".freeze |
There was a problem hiding this comment.
Minor: Is there a specific style reason to have another %w list delimiter for EXCLUDE than what PUNCT is using?
|
It may be nice if this method accepts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method generates a random pass phrase.