-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable to change the background color of dialogs. #413
Merged
peterzhu2118
merged 13 commits into
ruby:master
from
pocari:support-for-changing-the-background-color-of-dialogs
Jun 27, 2022
+83
−25
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
cc438de
Make it possible to set the background color of the dialog and the ba…
pocari 0bfeda1
Remove from the configuration items in inputrc
pocari dec9289
add config parameters
pocari e61c8d4
add config parameters
pocari a91c03d
support for foreground color
pocari 4d1e684
add default fg, bg color settings
pocari e427619
fix typo
pocari 99e90d3
Update lib/reline.rb
pocari 8bf9ca2
add space
pocari 6ccdcc5
Merge branch 'support-for-changing-the-background-color-of-dialogs' o…
pocari 28a64c6
use forwardable
pocari 3b72875
use attr_accessor
pocari 2302293
add dialog configuration test
pocari File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -743,17 +743,15 @@ def add_dialog_proc(name, p, context = nil) | |
Reline::IOGate.move_cursor_column(dialog.column) | ||
dialog.contents.each_with_index do |item, i| | ||
if i == pointer | ||
bg_color = '45' | ||
fg_color = dialog_render_info.pointer_fg_color | ||
bg_color = dialog_render_info.pointer_bg_color | ||
else | ||
if dialog_render_info.bg_color | ||
bg_color = dialog_render_info.bg_color | ||
else | ||
bg_color = '46' | ||
end | ||
fg_color = dialog_render_info.fg_color | ||
bg_color = dialog_render_info.bg_color | ||
end | ||
str_width = dialog.width - (dialog.scrollbar_pos.nil? ? 0 : @block_elem_width) | ||
str = padding_space_with_escape_sequences(Reline::Unicode.take_range(item, 0, str_width), str_width) | ||
@output.write "\e[#{bg_color}m#{str}" | ||
@output.write "\e[#{bg_color}m\e[#{fg_color}m#{str}" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This can be |
||
if dialog.scrollbar_pos and (dialog.scrollbar_pos != old_dialog.scrollbar_pos or dialog.column != old_dialog.column) | ||
@output.write "\e[37m" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe scrollbar color too? |
||
if dialog.scrollbar_pos <= (i * 2) and (i * 2 + 1) < (dialog.scrollbar_pos + bar_height) | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a test for this in
test_config.rb
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@peterzhu2118 I have added it. (d0559f8)