Kernel instance methods #1945
Kernel instance methods #1945
Conversation
| @@ -2782,8 +2779,7 @@ module Kernel : BasicObject | |||
| # | |||
| # See #respond_to?, and the example of BasicObject. | |||
| # | |||
| %a{annotate:rdoc:copy:Object#respond_to_missing?} | |||
| private def respond_to_missing?: (Symbol, bool) -> bool | |||
| private def respond_to_missing?: (Symbol | String name, bool include_all) -> bool | |||
There was a problem hiding this comment.
The default implementation doesn't actually check the arguments and always returns false, but the documentation says it can also take a String, so I added that.
There was a problem hiding this comment.
This is meant to be an abstract method but with a default implementation given.
sampersand
force-pushed
the
swesterman/24-08-01/Kernel_instance_methods
branch
8 times, most recently
from
0a3ac8c
to
b1a6b95
Compare
| @@ -2447,7 +2445,7 @@ module Kernel : BasicObject | |||
| # b.instance_of? B #=> true | |||
| # b.instance_of? C #=> false | |||
| # | |||
| def instance_of?: (Module) -> bool | |||
| def instance_of?: (Module | Class module_or_class) -> bool | |||
There was a problem hiding this comment.
Technically Class < Module, and the | Class is redundant.
There was a problem hiding this comment.
There was a problem hiding this comment.
While the | Class is technically redundant, i think it works well as a documentation—new ruby users might not know that all classes are modules, and might be confused as to why is_a? and friends don't say they accept Classes
There was a problem hiding this comment.
Has there been discussion in Ruby Core on making Class not outright inherit from Module?
Class is not a strict subtype of Module because of the many places that can complain “wrong argument type Class (expected Module) (TypeError)”.
include Class
|
|
||
| %a{annotate:rdoc:skip} | ||
| # <!-- |
There was a problem hiding this comment.
Wow, we have two RDoc entries for yield_self and then... 🤔
sampersand
force-pushed
the
swesterman/24-08-01/Kernel_instance_methods
branch
from
db0988c
to
81d239d
Compare
This PR updates all the instance methods on
Kernel, and also adds tests for them.