Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rbs diff] Fix error when empty manifest.yaml #1762

Merged
merged 1 commit into from
Mar 11, 2024
Merged

[rbs diff] Fix error when empty manifest.yaml #1762

merged 1 commit into from
Mar 11, 2024

Conversation

ksss
Copy link
Collaborator

@ksss ksss commented Mar 10, 2024

I have found a problem with an error when manifest.yaml exists but is all comments.

rbs/lib/rbs/diff.rb:86:in `block in build_env': undefined method `[]' for nil (NoMethodError)

          if manifest['dependencies']
                     ^^^^^^^^^^^^^^^^

soutaro
soutaro approved these changes Mar 11, 2024
View reviewed changes
Copy link
Member

@soutaro soutaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍

@soutaro soutaro added this to the RBS 3.5 milestone Mar 11, 2024
@soutaro soutaro added this pull request to the merge queue Mar 11, 2024
Merged via the queue into ruby:master with commit b28123c Mar 11, 2024
15 checks passed
@ksss ksss deleted the fix-diff branch March 11, 2024 01:39
@soutaro soutaro added the Released PRs already included in the released version label Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soutaro soutaro soutaro approved these changes

Assignees
No one assigned
Labels
Released PRs already included in the released version
Milestone
RBS 3.5
Development

Successfully merging this pull request may close these issues.
2 participants
@ksss @soutaro