net-http: Allow symbol based hashes for headers #1750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These methods work fine with headers given as `Hash[Symbol, untyped]`. I noticed when I got some squiggly lines in some of my methods that I already know work. I also defined `headers` as a type alias rather than copy-pasting the same definition everywhere (I can undo this if not desired). I did `(Hash[String, untyped] | Hash[Symbol, untyped])` rather than `Hash[String | Symbol, untyped]` because hashes with mixed key types can allow name collisions which gives unexpected behavior. I also feel like we can do better than `untyped` for the values, but leaving it for now.
ThisGuyCodes
changed the title
ThisGuyCodes
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These methods work fine with headers given as
Hash[Symbol, untyped]. I noticed when I got some squiggly lines in some of my methods that I already know work. I also definedheadersas a type alias rather than copy-pasting the same definition everywhere (I can undo this if not desired).I did
(Hash[String, untyped] | Hash[Symbol, untyped])rather thanHash[String | Symbol, untyped]because hashes with mixed key types can allow name collisions which gives unexpected behavior.I also feel like we can do better than
untypedfor the values, but leaving it for now.