Prevent resource leak with type/method-type parser when reaching EOF. #1742
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A static analyzer detected a resource leak.
alloc_parser
allocates via calloc. Then if thenext_token
type is EOF the parser is not freed and we return. I do not think this is registered with GC, since it is manually freed in the methods later on. Therefore my conclusion is that freeing it was forgotten, unless there is more going on than I am aware of.Local run of
bundle exec rake test
passed with Ruby 3.3.0.Output of the analyzer: