Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use protobuf encoding to serialize variable-length integers #927

Merged
merged 1 commit into from
May 24, 2023
Merged

Use protobuf encoding to serialize variable-length integers #927

merged 1 commit into from
May 24, 2023

Conversation

eregon
Copy link
Member

@eregon eregon commented May 23, 2023

@eregon
Use protobuf encoding to serialize variable-length integers
1be84ff 
* The serialized size/source size for all .rb files of the top 100 gems
  is 1.65x before and 0.89x after, so now serialized is smaller than the
  source for those files.
* This compresses the best and is still fast to encode and decode,
  see ruby#741
  and ruby#836
* Use io.getbyte instead of io.read(1).unpack1("C") as it is much faster.
@eregon eregon requested a review from jemmaissroff May 23, 2023 18:34
@jemmaissroff jemmaissroff merged commit a62b6aa into ruby:main May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jemmaissroff jemmaissroff jemmaissroff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eregon @jemmaissroff