Implement squiggly heredocs for the parser translator #3341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Earlopain
force-pushed
the
parser-translator-squigly-heredoc
branch
2 times, most recently
from
a179339 to
02c0a66
Compare
Earlopain
commented
Dec 23, 2024
| is_first_token_on_line = lexed[index - 1] && token.location.start_line != lexed[index - 2][0].location&.start_line | ||
| # The parser gem only removes indentation when the heredoc is not nested | ||
| not_nested = heredoc_stack.size == 1 | ||
| if is_first_token_on_line && not_nested && (heredoc = heredoc_stack[0]).common_whitespace > 0 |
There was a problem hiding this comment.
Any tip for getting this through sorbet? It complains that heredoc can be nil but that will never be the case because the previous condition checked that the first element is present.
When rewriting this into something that proves to sorbet that it can't be nil, it's telling me that the condition is always falsy.
This also fails:
index = 0
lexed = [:FIRST, :SECOND]
length = lexed.length
identifiers = []
while index < length
token = lexed[index]
index += 1
case token
when :FIRST
identifiers.push("abc")
when :SECOND
if (identifier = identifiers[0])
puts identifier
end
end
endIt seems to believe that the array is always empty
There was a problem hiding this comment.
Got a workaround from sorbet/sorbet#8401 (comment) that seems to work
Earlopain
force-pushed
the
parser-translator-squigly-heredoc
branch
from
02c0a66 to
302cc30
Compare
Earlopain
force-pushed
the
parser-translator-squigly-heredoc
branch
from
302cc30 to
8bbdc4f
Compare
This was referenced Dec 24, 2024
In parser, the string content is dedented. This implements these rules as far as I was able to understand them. It's all a bit confusing with spaces/tabs, always learning more funny things about them. I refered to the prism implementation, parser seems to adhere to it very closely.
Earlopain
force-pushed
the
parser-translator-squigly-heredoc
branch
from
8bbdc4f to
7bfd527
Compare
kddnewton
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In parser, the string content is dedented. This implements these rules as far as I was able to understand them. It's all a bit confusing with spaces/tabs, always learning more funny things about them.
I refered to the prism implementation, parser seems to adhere to it very closely.