Fix it lexing
#3325
Closed
Fix it lexing
#3325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given the following code:
```ruby
i=2; 42.tap { it /1/i }
```
Before this commit, the tokenizer would treat `it /1/i` as a method call
with a regular expression parameter. `it` is to be treated as a local
variable, so this needs to be tokenized as division rather than a
regular expression. In other words it should be tokenized as
`it / 1 / i`
This commit fixes tokenization.
[Bug #20970]
|
I think we're treating I'm not sure. |
|
Seems like we don't need this anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given the following code:
Before this commit, the tokenizer would treat
it /1/ias a method call with a regular expression parameter.itis to be treated as a local variable, so this needs to be tokenized as division rather than a regular expression. In other words it should be tokenized asit / 1 / iThis commit fixes tokenization.
[Bug #20970]
Bug is here: https://bugs.ruby-lang.org/issues/20970#change-111104
This makes the AST correct, but I haven't tested it with
prism_compile.c