Enable implicit fall-through errors #3324
Merged
+42
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amomchilov
changed the title
amomchilov
force-pushed
the
detect-implicit-fallthrough
branch
from
b81662a to
2389d0c
Compare
amomchilov
force-pushed
the
detect-implicit-fallthrough
branch
from
2389d0c to
03797b8
Compare
amomchilov
commented
Dec 18, 2024
| @@ -21893,6 +21893,7 @@ parse_expression(pm_parser_t *parser, pm_binding_power_t binding_power, bool acc | |||
| if (pm_symbol_node_label_p(node)) { | |||
| return node; | |||
| } | |||
| break; | |||
There was a problem hiding this comment.
This one had an implicit fall-through that wasn't annotated.
Since the default case it falls into only does a break, I just added its own break instead of PRISM_FALLTHROUGH.
tenderlove
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables
-Wimplicit-fallthroughto catch any potentially unintended fall-through betweencasebodies.The exiting
/* fallthrough */comments are now formalized with a newPRISM_FALLTHROUGHmacro which:[[fallthrough]]attribute, if available,__attribute__((fallthrough))on GCC and Clang__fallthroughon MSVC