Add Prism::Node#deprecated method type #2837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kddnewton
requested changes
May 24, 2024
templates/sig/prism/node.rbs.erb
Outdated
| @@ -33,6 +33,7 @@ module Prism | |||
| def fields: () -> Array[Prism::Reflection::Field] | |||
| def inspect: () -> String | |||
| def type: () -> Symbol | |||
| def deprecated: (*String) -> void | |||
There was a problem hiding this comment.
Can you put this on class Node? _Node is for the stuff that is implemented on each node.
There was a problem hiding this comment.
OK, I'll try it!
S-H-GAMELINKS
force-pushed
the
add/node-deprecated-method-type
branch
from
68abf64 to
400efbb
Compare
kddnewton
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
Prism::Node#deprecatedmethod type and supressdeprecatedmethod type error.