Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

all constant nodes should have full_name and full_name_parts methods #2485

Merged
merged 1 commit into from
Feb 22, 2024
Merged

all constant nodes should have full_name and full_name_parts methods #2485

merged 1 commit into from
Feb 22, 2024

Conversation

exterm
Copy link
Contributor

@exterm exterm commented Feb 22, 2024 •
edited
Loading

In reference to #2434 (reply in thread)

There's no specific test for node extensions, it seems? Not sure where I'd add a test for this.

kddnewton
kddnewton approved these changes Feb 22, 2024
View reviewed changes
Copy link
Collaborator

@kddnewton kddnewton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. There are tests in ruby_api test but I'm okay merging this as is

@kddnewton kddnewton merged commit c70c952 into ruby:main Feb 22, 2024
54 checks passed
@exterm exterm deleted the full_name_on_all_constant_nodes branch February 23, 2024 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kddnewton kddnewton kddnewton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@exterm @kddnewton