Ensure last encoding flag wins #1701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You can't encoding a string with more than one encoding so ensure that the last one wins.
HParker
pushed a commit
to HParker/yarp
that referenced
this pull request
Oct 18, 2023
Ensure last encoding flag wins
eregon
reviewed
Oct 18, 2023
| @@ -779,18 +779,21 @@ parse_decimal_number(pm_parser_t *parser, const uint8_t *start, const uint8_t *e | |||
| static inline pm_node_flags_t | |||
| pm_regular_expression_flags_create(const pm_token_t *closing) { | |||
| pm_node_flags_t flags = 0; | |||
| pm_node_flags_t mask = (uint16_t) 0xFF0F; | |||
There was a problem hiding this comment.
Could this be ~(PM_REGULAR_EXPRESSION_FLAGS_EUC_JP | PM_REGULAR_EXPRESSION_FLAGS_ASCII_8BIT | ...) instead? It seems brittle to hardcode flag values here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can't encoding a string with more than one encoding so ensure that the last one wins.