Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add username keyword param to start methods #72

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add username keyword param to start methods #72

wants to merge 1 commit into from

Conversation

nevans
Copy link
Contributor

@nevans nevans commented Oct 14, 2023

Although "user" is a reasonable abbreviation, the parameter is more accurately described as a "username" or an "authentication identity". They are synonymous here, with "username" winning when both are present.

To reduce merge conflicts, this PR includes:

This was referenced Oct 14, 2023
Open
Draft
Draft
@nevans nevans mentioned this pull request Oct 20, 2023
Merged
@nevans
Add username keyword param to start
26176ef 
Although "user" is a reasonable abbreviation, the parameter is more
accurately described as a "username" or an "authentication identity".
They are synonomous here, with "username" winning when both are present.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nevans