Use ruby2_keywords for authenticator forwarding #68
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, authenticators need to accept keywords for compatibility with older ruby versions. Ruby 2.6 will send an empty hash for
**properties
, and that can crash (or be interpreted as an optional argument) if the authenticator doesn't accept keyword arguments.Actually... is that a bad thing? Maybe the error will motivate people to upgrade to ruby 2.7+ or contribute their custom authenticators to net-imap? 😉
It's easy to stay compatible with
ruby2_keywords
, so let's do that.