🐛 Fix authenticate using Symbol mechanism name #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on `net-smtp`, I had added the ability to use symbols to lookup authenticator. But it had two issues: 1) dealing with dashes vs underscores, and 2) sending the mechanism name using flag syntax. This fixes both issues.
nevans
changed the title
nevans
force-pushed
the
sasl/symbol_mechanism_names
branch
from
34f3563
to
44f3c79
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on
net-smtp, I had added the ability to use symbols to lookup authenticator. But it had two issues: 1) dealing with dashes vs underscores, and 2) sending the command name using flag syntax. This fixes both issues.