Fix NoMethodError when "qop" is not present

ruby · Jul 26, 2023 · 2a85ac1 · 2a85ac1
1 parent 63ebe2f
commit 2a85ac1
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/lib/net/imap/authenticators/digest_md5.rb b/lib/net/imap/authenticators/digest_md5.rb
@@ -26,7 +26,7 @@ def process(challenge)
         sparams[k] = v
       end
 
-      raise Net::IMAP::DataFormatError, "Bad Challenge: '#{challenge}'" unless c.eos?
+      raise Net::IMAP::DataFormatError, "Bad Challenge: '#{challenge}'" unless c.eos? and sparams['qop']
       raise Net::IMAP::Error, "Server does not support auth (qop = #{sparams['qop'].join(',')})" unless sparams['qop'].include?("auth")
 
       response = {

diff --git a/test/net/imap/test_imap_authenticators.rb b/test/net/imap/test_imap_authenticators.rb
@@ -160,4 +160,11 @@ def test_digest_md5_authenticator_garbage
       auth.process('.')
     end
   end
+
+  def test_digest_md5_authenticator_no_qop
+    auth = digest_md5("user", "pass")
+    assert_raise(Net::IMAP::DataFormatError) do
+      auth.process('Qop=""')
+    end
+  end
 end