feature detect to make net/http usable with JRuby #52
Conversation
JRuby can not implement these using available SSL engine APIs
as it issues a warn-ing message under JRuby
| OpenSSL::SSL::SSLContext::SESSION_CACHE_CLIENT | | ||
| OpenSSL::SSL::SSLContext::SESSION_CACHE_NO_INTERNAL_STORE | ||
| @ssl_context.session_new_cb = proc {|sock, sess| @ssl_session = sess } | ||
| unless @ssl_context.session_cache_mode.nil? # a dummy method on JRuby |
There was a problem hiding this comment.
If JRuby doesn't support @ssl_context.session_cache_mode, maybe don't define the method and use if defined?(@ssl_context.session_cache_mode).
There was a problem hiding this comment.
Yes, we probably should do that, but we implemented it as a no-op plus warning so we might be reluctant to remove the method all together.
There was a problem hiding this comment.
👍 the reasoning being session_cache_mode does not affect the user-code much overall and thus it existed for some time and removing it might be considered breaking ... thus the nil compromise will probably stay with us.
smt like session_new_cb, while being "low" level, tends to get much more critical in user-code - if we had it as a dummy attr and the callback never fired it would be counter productive ...
|
I think this is ready to merge. It would be helpful to us completing work on JRuby 9.4 if we could get this into a gem (possibly prerelease). |
There was a problem hiding this comment.
Generally it looks good to me.
@jeremyevans, could you merge this if you also think loos good
|
Can we get a gem pushed (preview is ok) so we can hook it up to JRuby's build and start using the gem? |
|
@headius I send an invitation of net-http owner. Can you confirm it? |
|
@hsbt thank you! I will push a pre gem today. |
up till JRuby 9.3 (Ruby 2.6 compatibility) JRuby shipped a slightly patched version of net/http to work-around some of the limitations - mostly of JRuby-OpenSSL which is implemented on top of Java APIs (does not use OpenSSL).
for JRuby 9.4, which is in development atm, it would be nice to be able to ship the gem version of net/http - the changes here represent an effort to make things compatible, there's really one important change:
SSLContext#session_new_cbin not implemented under JRuby, it could be a dummy no-op but this would confuse users as these session_xxx callbacks do not get actually called (no way to hook into session management on the Java SSL engine end)SSLContext#session_cache_mode=historically exist in JRuby but is effectively a no-op and issues aKernel.warn, theSSLContext#session_cache_modereader always returnsnilas an attempt to be able to "feature-detect"