Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for stdin mode #46

Merged
merged 1 commit into from
Jun 23, 2023
Merged

Conversation

alitaso345
Copy link
Contributor

Summary

Changes Made

  • Add tests in command_spec.rb
    • normal mode case(e.g., lrama -d parse.y -o parse.c)
    • stdin mode case(e.g., ruby tool/id2token.rb parse.y | lrama -d - parse.y -o parse.c)
    • invalid cases

Issues I want to consult on

  • I added spec/fixtures/command/basic.y to use normal input test.
  • I copied a grammar file from sample/calc.y to spec/fixtures/command. The contents of the file do not have significant meaning.
  • If the above approach is inappropriate, could you please give me some advice?

There are the tests corresponding to the following implementation ruby#8
@yui-knk yui-knk merged commit d52904a into ruby:master Jun 23, 2023
@yui-knk
Copy link
Collaborator

yui-knk commented Jun 23, 2023

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants