Add support --report=terms option
#439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ydah
reviewed
Jun 8, 2024
There was a problem hiding this comment.
Thank you! This is a very useful reporting feature!
I think the implementation is good. However, isn't it not possible to execute it as a command since there is no term option?
lrama/lib/lrama/option_parser.rb
Lines 94 to 97 in 5bed7c9
S-H-GAMELINKS
force-pushed
the
add-unused-term-report
branch
from
2745b77 to
d2b1d5c
Compare
|
Certainly, I had forgotten about the part about passing in terms option for command. |
ydah
reviewed
Jun 8, 2024
S-H-GAMELINKS
force-pushed
the
add-unused-term-report
branch
from
d2b1d5c to
c81d0ed
Compare
|
@S-H-GAMELINKS Ah, sorry. Could you change the title of the commit message and PR to say that you have added support for the |
S-H-GAMELINKS
force-pushed
the
add-unused-term-report
branch
from
c81d0ed to
28b1eb3
Compare
S-H-GAMELINKS
changed the title
--report=terms option
|
OK, I have rewritten PR titile and commit message. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add report_unused_terms private method to Lrama::StatesReporter for
TODO Unused termsinlib/lrama/states_report.rbHowever, I am not sure if the output format is what it is supposed to be, so I would appreciate your comments if it is different.