Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use StringIO.new instead of "" #427

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Use StringIO.new instead of "" #427

merged 1 commit into from
Jun 5, 2024

Conversation

ydah
Copy link
Collaborator

@ydah ydah commented Jun 2, 2024

Follow up: #424

@ydah ydah force-pushed the fixes-string-issue branch from 9f6bee2 to 1bdf870 Compare June 3, 2024 14:45
@ydah ydah mentioned this pull request Jun 3, 2024
Merged
junk0612
junk0612 approved these changes Jun 3, 2024
View reviewed changes
Copy link
Collaborator

@junk0612 junk0612 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me. Thanks for following up.

@ydah ydah force-pushed the fixes-string-issue branch from 1bdf870 to 69c22e1 Compare June 5, 2024 05:41
@ydah ydah merged commit 7b3e516 into ruby:master Jun 5, 2024
16 checks passed
@ydah ydah deleted the fixes-string-issue branch June 5, 2024 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junk0612 junk0612 junk0612 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ydah @junk0612