add grammar/code directory types #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yui-knk
reviewed
May 17, 2024
| def reference_to_c: (Reference ref) -> String | ||
| def position_in_rhs: () -> Integer | ||
| def rhs: () -> Array[Grammar::Symbol] | ||
| def lhs: () -> Symbol |
There was a problem hiding this comment.
Is there any intention to use "Symbol" however rhs is Grammar::Symbol.
There was a problem hiding this comment.
Sorry, seems like a simple mistake. I fixed.
yui-knk
approved these changes
May 17, 2024
|
Thanks for the PR! This is OSS project then you do not need to apologize the pace of your work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's been a while since I added types. (sorry...)
The surroundings directory in Grammar is quite complex, with many uncertainties, but I have confirmed that all type checks are cleared.